test(Mover): Add test for moving complex expression blocks right/left move tests
#711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creaet a new test helper appendBlock, that will create a new block from JSON and connect it as requested.
This means the test blocks don't need to include the block(s) to be moved.
This means the test blocks don't need to include the block(s) to be moved, which considerably simplifies adding several more test cases.
Use an unconnected (top-level) block with two empty value inputs, to allow us to better compare order of visiting inputs vs. outputs of top-level blocks.
RoboErikG
approved these changes
Sep 3, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
Changes LGTM. Is the failing test (Start moving value blocks) the flaky one?
Collaborator
Author
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on move tests, including some tweaks to the stack block move test code added by PR #710:
appendBlocktest helper, to make it easy to attach several different blocks in sequence to the same test block layout.appendBlock.followed by completing the testing of (well-defined) constrained block movement by adding adding tests for moving complex expression blocks (ones with multiple inputs) right and left.
Fixes #696.